Doc and comment fixes from #4167#4178
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Oct 28, 2025
Merged
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4178 +/- ##
==========================================
+ Coverage 88.80% 88.82% +0.01%
==========================================
Files 180 180
Lines 137262 137262
Branches 137262 137262
==========================================
+ Hits 121901 121928 +27
+ Misses 12553 12529 -24
+ Partials 2808 2805 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tankyleo
reviewed
Oct 27, 2025
TheBlueMatt
force-pushed
the
2025-10-upgrade-scid-timeout
branch
from
33273b2 to
a745439
Compare
tankyleo
reviewed
Oct 27, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
TheBlueMatt
force-pushed
the
2025-10-upgrade-scid-timeout
branch
from
a745439 to
ab21871
Compare
tankyleo
approved these changes
Oct 27, 2025
Collaborator
Author
|
This is trivial. |
Merged
Collaborator
Author
|
Backported to 0.2 in #4185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes incorrect docs and comments introduced by e95ebf8 and
491b694